Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to rename custom properties #803

Merged
merged 1 commit into from
Oct 26, 2014

Conversation

Arnaud-Trouche
Copy link

Resolve the issue #772 "Can't rename custom properties in Properties window"

A button is added to the interface in order to be able to rename the custom properties, and only custom properties. Here a screenshot of the changes in the GUI
capture d ecran 2014-10-17 a 12 30 15

The "pen" button is the rename property icon.

(sorry for the second pull-request :s)

@bjorn
Copy link
Member

bjorn commented Oct 19, 2014

I haven't checked, but judging by the code this will cause the undo stack to have two entries for the rename. Could you look into making it one? One way of doing this is to use QUndoStack::beginMacro and endMacro.

@bjorn bjorn merged commit 5de1bf0 into mapeditor:master Oct 26, 2014
bjorn added a commit that referenced this pull request Oct 26, 2014
Ability to rename custom properties
@bjorn
Copy link
Member

bjorn commented Oct 26, 2014

I've decided to tackle the remaining issues with this change after merging in commit ee41a53. Thanks for your help on this feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants