Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortcut to reload tilesets. #165

Closed
wants to merge 1 commit into from
Closed

Add shortcut to reload tilesets. #165

wants to merge 1 commit into from

Conversation

mtwilliams
Copy link
Contributor

Although hot-reloading is available for tilesets manual control is sometimes required (wanted) so now Ctrl+T reloads the current map's tilesets.

@bjorn
Copy link
Member

bjorn commented Mar 11, 2012

Thanks for your patch, but could you adapt it to use the existing coding style? Tiled uses the Qt coding style. This means:

  • Pointer types have the * at the variable name, not at the type.
  • There are no spaces on the inside of parenthesis.
  • There is a space between an if and its opening parenthesis.
  • When a loop body is only a single line, the curly brackets are left out.

Why the addition of the unused forceTilesetReloadByName and forcceTilesetReloadBySource functions?

I guess the shortcut could be Ctrl+R rather than Ctrl+T?

@mtwilliams
Copy link
Contributor Author

Valid concerns. I'll fix the issues up later today.

Edit:

Been swamped lately. I'll try and get around to it soon.

@flexd
Copy link

flexd commented Apr 7, 2012

+1

@Gornova
Copy link
Contributor

Gornova commented May 31, 2012

+1 for this maybe shortcut could be configurable?

@bjorn
Copy link
Member

bjorn commented May 31, 2012

@Gornova There are currently no configurable shortcuts in Tiled. Why should this one in particular be configurable? Just saying I'd rather see a solution that would allow configuring all shortcuts, if any.

@mtwilliams This patch seems to be quite popular. Do you still expect to get around to updating it? If not I could also amend the patch for you.

@Gornova
Copy link
Contributor

Gornova commented May 31, 2012

In my experience as programmer when someone starts to use shortcuts, then need to configure it, a simple table fo configure them all could be useful (not only this, for anyone in Tiled). Do you want I open a specific issue for this ?

@bjorn
Copy link
Member

bjorn commented May 31, 2012

Feel free to open an issue about it, but it's unlikely I will get around to work on it.

@Gornova
Copy link
Contributor

Gornova commented May 31, 2012

ok, see #215

@bjorn
Copy link
Member

bjorn commented Aug 11, 2012

I've adapted this patch to conform to the coding style and pushed it as bd17698.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants