Link zstd static library instead of dynamic library on windows #2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oipo
changed the title
|
Would recommend squashing the commits, as I couldn't be bothered using proper commit messages. |
|
Right, I was just testing a similar commit (d4d9b85). Thanks for cleaning this up! |
Applications depending on libtiled do not need zstd header files in their include path.
|
Happy to help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, cpp.staticLibraries also looks for dynamic libraries. Made it so that the dynamic library does not get build on windows, so it cannot be linked. Turns out that there's no need to differentiate between platforms anymore.