Attempt to fix java tile type bug #2704
Conversation
This code *should* work, but I'm unable to compile & test it with my setup. I don't understand how jaxb is setup. The main possible failure is if the .getTile() function isn't actually generated by jaxb. Closes mapeditor#2128
There was a problem hiding this comment.
Thanks for fixing this issue!
Indeed the fix looks fine, though I think the code could use some unification because it's becoming really ugly that "tiles with an image" are a different branch than those without.
But I'd merge this anyway if you fix the indentation. :-)
util/java/libtiled-java/src/main/java/org/mapeditor/io/TMXMapWriter.java
Outdated
Show resolved
Hide resolved
What error are you getting exactly? I personally am having trouble compiling |
There was a problem hiding this comment.
I don't have a working command-line copy of maven, so I can't even start the build. Maven fails to install because it gets confused - I have both java 8 and java 11 installed, and manually set up IDE's to resolve conflicts. Can't do that with command line tools.
This code should work, but I'm unable to compile & test it with my
setup. I don't understand how jaxb is setup. The main possible failure
is if the .getTile() function isn't actually generated by jaxb.
Closes #2128 if merged.