Document all optional attributes, update some docs #2705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All optional attributes are now marked as optional. All attributes have a default value, if applicable. A new line was added at the top of the docs to clearly state that all optional and default fields are correctly marked. Made the default value wording consistent throughout all attributes. Additionally, I documented previously undocumented behavior in wangtile, and updated the supported encodings to include "zstd".
bjorn
requested changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All optional attributes are now marked as optional. All attributes have
a default value, if applicable. A new line was added at the top of the
docs to clearly state that all optional and default fields are correctly
marked. Made the default value wording consistent throughout all
attributes.
Additionally, I documented previously undocumented behavior in wangtile,
and updated the supported encodings to include "zstd".
Followup on #2702, improving #696 solution.