Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added checks for nullptr in script arguments #2736

Merged
merged 2 commits into from
Jan 21, 2020
Merged

Added checks for nullptr in script arguments #2736

merged 2 commits into from
Jan 21, 2020

Conversation

Phlosioneer
Copy link
Contributor

@Phlosioneer Phlosioneer commented Jan 17, 2020 •
edited by bjorn
Loading

QJSEngine can pass a nullptr to a Q_INVOKABLE or Q_PROPERTY function if the argument is either undefined or the wrong type.

@Phlosioneer
Added checks for nullptr in script arguments
b40e1dd 
QJSEngine can pass a nullptr to a Q_INVOKEABLE or Q_PROPERTY function
if the argument is either `undefined` or the wrong type.
@Phlosioneer Phlosioneer mentioned this pull request Jan 17, 2020
Closed
bjorn
bjorn requested changes Jan 17, 2020
View reviewed changes
Copy link
Member

@bjorn bjorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, lots of checks I missed. Thanks for making the API a little more stable!

src/tiled/editablemap.cpp Outdated Show resolved Hide resolved
src/tiled/scriptmanager.cpp Outdated Show resolved Hide resolved
@bjorn bjorn merged commit c4244d2 into mapeditor:master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn bjorn bjorn requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Phlosioneer @bjorn