Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various little fixes and tweaks #53

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Various little fixes and tweaks #53

wants to merge 8 commits into from

Commits on Sep 20, 2021

  1. Fixe dindentation in codePush.sync's documentation comment 

    Signed-off-by: Clovis Durand <cd.clovel19@gmail.com>
    @Clovel
    Clovel committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    6b83ede View commit details
    Browse the repository at this point in the history

  2. Added log for the InstallMode.IMMEDIATE case in syncInternal.onInstal… 

    …lSuccess

Signed-off-by: Clovis Durand <cd.clovel19@gmail.com>
    @Clovel
    Clovel committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    2c4ad78 View commit details
    Browse the repository at this point in the history

  3. Fixed indentation inside of checkForUpdate's implementation 

    Signed-off-by: Clovis Durand <cd.clovel19@gmail.com>
    @Clovel
    Clovel committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    a0e990a View commit details
    Browse the repository at this point in the history

  4. Replaced var by const in checkForUpdate 

    Signed-off-by: Clovis Durand <cd.clovel19@gmail.com>
    @Clovel
    Clovel committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    4406c72 View commit details
    Browse the repository at this point in the history

  5. Print the binary versions if an update is available, but it is target… 

    …ing a newer binary

Signed-off-by: Clovis Durand <cd.clovel19@gmail.com>
    @Clovel
    Clovel committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    2784ab8 View commit details
    Browse the repository at this point in the history

  6. Added comments to checkForUpdate 

    Signed-off-by: Clovis Durand <cd.clovel19@gmail.com>
    @Clovel
    Clovel committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    b82ee09 View commit details
    Browse the repository at this point in the history

  7. Explicit boolean conditional in sync when checking CodePush.SyncInPro… 

    …gress

Signed-off-by: Clovis Durand <cd.clovel19@gmail.com>
    @Clovel
    Clovel committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    10c327f View commit details
    Browse the repository at this point in the history

  8. Compiled project 

    Signed-off-by: Clovis Durand <cd.clovel19@gmail.com>
    @Clovel
    Clovel committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    80b62fe View commit details
    Browse the repository at this point in the history