Regression fix: allow build without tests #640
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@YanNoun has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
mlopezantequera
pushed a commit
that referenced
this pull request
Oct 9, 2020
* master: fix: do not init glog (#653) chore: remove Python 2/3 doc chore: remove six chore: remove future imports feat: prepare for overload GCP loading feat: add manifold IO fix: fix division by zero bug feat: fix command line chore: fix typo in TopoCentriConverter Re-sync with internal repository Small fixes with big impact Fixed pickle error, deprecation warning (#645) Regression fix: allow build without tests (#640) refactor: seperate action from commands refactor: unify OpenSfM and mapillary_sfm commands under a common umbrella Feat: bundle and bundle_local in C++ (#628) fix: make test green ! fix camera test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello ✋
I'm so excited for all the new changes in OpenSfM!
While building it with
-DOPENSFM_BUILD_TESTS=OFFI noticed that tests were being built anyway (it slows down build time, requires a few extra dependencies).This PR makes building tests conditional (I think this is a regression since it was working OK with previous releases).
Hope this can be useful for others.