fix: no make_unique pre-C++14 #688
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@YanNoun has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
mlopezantequera
pushed a commit
that referenced
this pull request
Jan 28, 2021
* origin/master: (29 commits) build: use C++14 (#697) Fix parameter names vlfeat: avoid build warnings fix: GPS Altitude extraction (#648) Add new cameras to exif Add radial and simple_radial model to io Camera tests clean-up (4/n) Add SimpleRadial as Radial unit test (3/n) Add projection functions for radial/simple_radial (2/n) Add Radial/Simple_Radial types and create methods (1/n) Clean-up remaining Eigen::XX types Add unit tests for fisheye/fisheye62 Fix: Return all distortion parameters from Python Add static method to get projection string fix: relax camera focal to prevent holes feat: statistics and report (#672) fix: no make_unique pre-C++14 (#688) feat: download merge rounds feat: add tracks merging Add option to use different cameras for images with unknown camera models ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at fixing the use make_unique.