mapillary-js viewer #698
mapillary-js viewer #698
Conversation
oscarlorentzon
force-pushed
the
feature-mjs-viewer
branch
from
586b135 to
ac36f03
Compare
There was a problem hiding this comment.
looking forward to using MapillaryJS as viewer. Thanks @oscarlorentzon !
There was a problem hiding this comment.
@paulinus has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Add OpenSfM data provider for fetching data. Configuration through dat.gui and key bindings. Fetch viewer dependencies with shell script. Add UI for selecting reconstruction files. Handle non existing images folder by creating and returning a fallback buffer.
Make separation of concerns clearer by creating classes.
Add namespace to CSS classes to avoid conflicts.
Make it possible to load multiple reconstruction files on initial load. Succeed if at least one of the files could be loaded.
Parse single file or comma separated files and load all of them. Succeed if at least one file can be fetched.
Separate thumbnail controller logic from info controller.
Rename cancellation error.
Handle config changes in viewer class. Emit changes from key and dat controllers.
Move all reusable classes and functions to opensfm-viewer.js file.
Move popup logic to separate class to reuse in key commands explainer and copier.
Set z-index to ensure popup always on top.
oscarlorentzon
force-pushed
the
feature-mjs-viewer
branch
from
0a7afc4 to
3482723
Compare
There was a problem hiding this comment.
@paulinus has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@paulinus has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
oscarlorentzon
force-pushed
the
feature-mjs-viewer
branch
from
d2afb07 to
ac7e51c
Compare
There was a problem hiding this comment.
@oscarlorentzon has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@oscarlorentzon merged this pull request in 7089ae0. |
This PR adds a viewer using
mapillary-js. By usingmapillary-jsthe client code can take advantage of new features automatically in the future.The diff consists of:
mapillary-js,gl-matrix, anddat.gui.