Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popup content shown in wrong place when visibility is set to visible #289

Closed
oscarlorentzon opened this issue Dec 6, 2018 · 0 comments
Closed

Popup content shown in wrong place when visibility is set to visible #289

oscarlorentzon opened this issue Dec 6, 2018 · 0 comments
Assignees
@oscarlorentzon
Labels
affects-component bug
Milestone
2.14.1

Comments

@oscarlorentzon
Copy link
Member

Basic information

MapillaryJS version: 2.6.0
System/Browser: All

Steps to Reproduce Behavior

  1. Add a clean popup to the center of a full panorama at (0.5, 0.5). Set the visibility of the popup content container to visible.
  2. Set the center of the viewer to the seam of the panorama at (1, 0.5).

Expected behavior

The popup disappears.

Actual behavior

The popup stays at the canvas coordinate where it was correctly shown before calling viewer.setCenter.

Additional information

This only happens when set center is called because when drag-panning the popup is moved out of the viewport.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oscarlorentzon oscarlorentzon

Labels
affects-component bug
Projects
None yet
Milestone
2.14.1
Development

No branches or pull requests
1 participant
@oscarlorentzon