fix: getExpectedAmount gas savings (C4 #62)
#45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #4304: [c4] Issue #62 - colalteralAssetDecimals gas optimization. |
deluca-mike
force-pushed
the
sc-4307-c4-issue-66-handleclaimofrepossessed-gas
branch
from
a711ab3
to
4a4c954
Compare
deluca-mike
force-pushed
the
sc-4304-c4-issue-62-colalteralassetdecimals-gas-optimization
branch
from
78e34d4
to
0f8bfc7
Compare
deluca-mike
added a commit
that referenced
this pull request
Dec 12, 2021
deluca-mike
added a commit
that referenced
this pull request
Dec 12, 2021
Base automatically changed from
sc-4307-c4-issue-66-handleclaimofrepossessed-gas
to
main
December 12, 2021 23:32
lucas-manuel
changed the title
getExpectedAmount gas savings (c4 #62)getExpectedAmount gas savings (C4 #62)
lucas-manuel
deleted the
sc-4304-c4-issue-62-colalteralassetdecimals-gas-optimization
branch
lucas-manuel
pushed a commit
that referenced
this pull request
Dec 12, 2021
lucas-manuel
added a commit
that referenced
this pull request
Dec 12, 2021
* fix: Input validation for `setAllowedSlippage` (c4 #45) * fix: use underscore syntax for 10k Co-authored-by: Lucas Manuel <lucas@maple.finance>
lucas-manuel
pushed a commit
that referenced
this pull request
Dec 13, 2021
* chore: Remove TODO on pullFunds (c4 #10) * chore: strict 0.8.7 (c4 #23) * fix: Add named returns where missing (c4 #25) * fix: `handleClaimOfRepossessed` gas optimization (c4 #66) * fix: `getExpectedAmount` gas savings (c4 #62) * fix: Use `!= 0` instead of `> 0` (c4 #24) * fix: Input validation for `setAllowedSlippage` (c4 #45) * refactor: POst-C4 Audit Cleanup - natspec, spacing, and alignment - factory `mapleGlobals_` check now handled by mpf - `success_` -> `success` for non-param variable - reordered `DebtLockerStorage` - take latest dependencies - `acceptNewTerms` gas savings - `claim`, `_handleClaimOfRepossessed`, and `_handleClaim` gas savings - `_isLiquidationActive` gas savings - `triggerDefault` gas savings Co-authored-by: Joao Gabriel Carvalho <jg@jgcarv.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses code-423n4/2021-12-maple-findings#62
Integrations Checklist
Changelog
Function Signature Changes
Features
Events