Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use != 0 instead of > 0 (c4 #24) #46

Merged
merged 1 commit into from
Dec 12, 2021
Merged

fix: Use != 0 instead of > 0 (c4 #24) #46

merged 1 commit into from
Dec 12, 2021

Conversation

deluca-mike
Copy link
Contributor

@deluca-mike deluca-mike commented Dec 12, 2021 •
edited by lucas-manuel
Loading

Description

Addresses code-423n4/2021-12-maple-findings#24

Integrations Checklist

  • Have any function signatures changed? If yes, outline below.
  • Have any features changed or been added? If yes, outline below.
  • Have any events changed or been added? If yes, outline below.
  • Has all documentation been updated?

Changelog

Function Signature Changes

Features

Events

@deluca-mike deluca-mike self-assigned this Dec 12, 2021
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #4291: [c4] Issue #24 - Use != 0.

Base automatically changed from sc-4304-c4-issue-62-colalteralassetdecimals-gas-optimization to main December 12, 2021 23:36
@lucas-manuel lucas-manuel merged commit b84aa00 into main Dec 12, 2021
@lucas-manuel lucas-manuel deleted the sc-4291-c4-issue-24-use-0 branch December 12, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-manuel lucas-manuel lucas-manuel approved these changes

@JGcarv JGcarv Awaiting requested review from JGcarv

Assignees

@deluca-mike deluca-mike

Labels
Priority: Medium Status: Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deluca-mike @lucas-manuel