Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: test_permitBadV #28

Merged
merged 4 commits into from
Mar 14, 2022
Merged

fix: test_permitBadV #28

merged 4 commits into from
Mar 14, 2022

Conversation

edag94
Copy link
Contributor

@edag94 edag94 commented Mar 14, 2022

  • fix test_permitBadV where tokens inheriting the erc20 test cases might have a different v value for the permit signature due to different DOMAIN_SEPERATOR

vbidin
vbidin previously approved these changes Mar 14, 2022
View reviewed changes
@lucas-manuel lucas-manuel merged commit 8d55417 into main Mar 14, 2022
@lucas-manuel lucas-manuel deleted the fix_test_permitBadV branch March 14, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-manuel lucas-manuel lucas-manuel left review comments

@vbidin vbidin vbidin left review comments

Assignees
No one assigned
Labels
Priority: High Status: Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edag94 @vbidin @lucas-manuel