Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update transferFrom to include Approval event (SC-3681) #7

Merged

Conversation

lucas-manuel
Copy link

@lucas-manuel lucas-manuel commented Sep 6, 2021

Description

PR closes #5

Integrations Checklist

  • Have any function signatures changed? If yes, outline below.
  • Have any features changed or been added? If yes, outline below.
  • Have any events changed or been added? If yes, outline below.
  • Has all documentation been updated?

Changelog

Function Signature Changes

Features

Events

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #3681: [erc20] Update transferFrom to include Approve event.

@lucas-manuel lucas-manuel changed the title fix: Update transferFrom to include Approve event (SC-3681) fix: Update transferFrom to include Approval event (SC-3681) Sep 6, 2021
@lucas-manuel lucas-manuel merged commit d3d4ebd into main Sep 7, 2021
@lucas-manuel lucas-manuel deleted the ch3681-erc20-update-transferfrom-to-include-approve branch September 7, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Should emit Approval event during transferFrom() function call
3 participants