comment minor fix

mapleFU · Mar 16, 2024 · 1bdf592 · 1bdf592
1 parent b78eed0
commit 1bdf592
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/cpp/src/parquet/bloom_filter_reader_writer_test.cc b/cpp/src/parquet/bloom_filter_reader_writer_test.cc
@@ -28,7 +28,7 @@
 namespace parquet::test {
 
 TEST(BloomFilterReader, ReadBloomFilter) {
-  std::string dir_string(parquet::test::get_data_dir());
+  std::string dir_string(get_data_dir());
   std::string path = dir_string + "/data_index_bloom_encoding_stats.parquet";
   auto reader = ParquetFileReader::OpenFile(path, false);
   auto file_metadata = reader->metadata();
@@ -59,7 +59,7 @@ TEST(BloomFilterReader, ReadBloomFilter) {
 TEST(BloomFilterReader, FileNotHaveBloomFilter) {
   // Can still get a BloomFilterReader and a RowGroupBloomFilter
   // reader, but cannot get a non-null BloomFilter.
-  std::string dir_string(parquet::test::get_data_dir());
+  std::string dir_string(get_data_dir());
   std::string path = dir_string + "/alltypes_plain.parquet";
   auto reader = ParquetFileReader::OpenFile(path, false);
   auto file_metadata = reader->metadata();

diff --git a/cpp/src/parquet/column_writer_test.cc b/cpp/src/parquet/column_writer_test.cc
@@ -1706,8 +1706,7 @@ class TestBloomFilterWriter : public TestPrimitiveWriter<TestType> {
   }
 
   std::shared_ptr<TypedColumnWriter<TestType>> BuildWriterWithBloomFilter(
-      int64_t output_size = SMALL_SIZE,
-      const ColumnProperties& column_properties = ColumnProperties());
+      int64_t output_size = SMALL_SIZE, const ColumnProperties& column_properties);
 
   std::unique_ptr<BloomFilterBuilder> builder_;
   BloomFilter* bloom_filter_;
@@ -1761,7 +1760,7 @@ TYPED_TEST(TestBloomFilterWriter, Basic) {
   this->GenerateData(SMALL_SIZE);
   ColumnProperties column_properties;
   BloomFilterOptions options;
-  options.ndv = 10;
+  options.ndv = SMALL_SIZE;
   column_properties.set_bloom_filter_options(options);
 
   auto writer = this->BuildWriterWithBloomFilter(SMALL_SIZE, column_properties);