Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix queryRenderedFeaturesInRect for iOS #10

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Fix queryRenderedFeaturesInRect for iOS #10

merged 1 commit into from
Oct 5, 2021

Conversation

michael-markl
Copy link

We noticed a bug in the method queryRenderredFeaturesInRect which only occurs on iOS. After detecting where the problem is, we want to contribute and fix this bug upstream.

@michael-markl
Copy link
Author

@mindthefish @m0nac0 I think in order to get this merged someone has to approve that the checks may run on this commit.

@mindthefish
Copy link

@mindthefish @m0nac0 I think in order to get this merged someone has to approve that the checks may run on this commit.

I approved the changes yesterday. What else can I do? I think @m0nac0 is the only one merging rights.

@m0nac0
Copy link
Collaborator

m0nac0 commented Oct 3, 2021

@Schedulaar Thank you for submitting the fix!

Could you please merge the current main into your fork? The CI is running on an outdated version of the workflow file (the one in your fork). That currently causes the iOS workflow to fail.

@m0nac0 m0nac0 merged commit 3d966de into maplibre:main Oct 5, 2021
@m0nac0
Copy link
Collaborator

m0nac0 commented Oct 5, 2021

@Schedulaar Nevermind, I merged it because the failing check is just a "quirk" of Github Actions. To be honest, I'm a bit surprised it would continue to use the old Github Actions .yml file...
The CI ran correctly after the merge.

@michael-markl
Copy link
Author

Alright, thanks for merging :)

@m0nac0
Copy link
Collaborator

m0nac0 commented Oct 5, 2021

Thank you for submitting!

Out of curiosity: have you submitted this upstream to tobrun/flutter-mapbox-gl? It's probably affected as well.

@michael-markl
Copy link
Author

No, I haven't... As of right now, we cannot use flutter-mapbox-gl anymore because of the license issues in newer versions of mapbox...

@m0nac0
Copy link
Collaborator

m0nac0 commented Oct 5, 2021

Ah, I see. Well, maybe someone (possibly even me if I find the time ;) will cherry-pick it for upstream at some point (and you'll get credit for it twice).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants