✨attributionButtonPosition for web

[ouvreboite]

Fix for: #283

• implement attributionButtonPosition for the web target
  • in maplibre_gl_web/lib/src/mapbox_web_gl_platform.dart, we default to attributionControl: false in the _map constructor, as the attributionControl is set later when setAttributionButtonAlignment is called.
  • ℹ️ It's similar to the example given in https://maplibre.org/maplibre-gl-js/docs/examples/attribution-position/ that also sets attributionControl to false in order to set manually the position.
• interop scaffolding done
  • Matches maplibre-gl-js attribution_control.ts
  • the compact and customAttribution options are not used currently. I'm not sure if they exists in iOS/Android.
• new "attribution" example page
  • it uses a osm_style.json exposed as an asset, as the web target does not support hardcoded styles
  • the no_location example is updated to also use osm_style.json, to make it work correctly in web

Attribution example page

[m0nac0]

For me on Firefox and Chromium browsers on Windows, the attribution looks wrong, it's just red text and has no white background and no info icon. Do you have any idea of what might be going wrong?

Edit: This actually also occurs with the example app from the main branch (but can only be seen when I change the no_location_permission page such that the style is not inlined, because otherwise the style is not loaded at all)

[m0nac0]

Two more points:

• the path to the style asset seems to be wrong and doesn't work on Android/iOS. I think it should be assets/osm_style.json
• passing null for attributionButtonPosition does not hide the attributionButton on Android/iOS in the existing implementations. So for now I think web should also use the default position when null is passed. To show no attribution, there was a previous PR Remove attribution button #174 using a new parameter for that. We could also discuss your approach, but I think that should be then implemented on all 3 platforms and it would be a breaking change.

I also noticed while testing this PR that on Android, attribution for the sources is currently missing from the attribution dialog. I opened #308 for this, but it is unrelated to your work

[ouvreboite]

@m0nac0 any other things you would like me to address ?

[m0nac0]

Thank you for your contribution and your patience! Looks very fine to me.

[m0nac0]

For me on Firefox and Chromium browsers on Windows, the attribution looks wrong, it's just red text and has no white background and no info icon. Do you have any idea of what might be going wrong?

Edit: This actually also occurs with the example app from the main branch (but can only be seen when I change the no_location_permission page such that the style is not inlined, because otherwise the style is not loaded at all)

By the way: I solved this by upgrading flutter.