make feature tap detection work for features with a null id on ios (same as android)

[lunaticcoding]

Feature Id nullable on android but not on iOS.

On android the feature id can be null which works fine in our app but on iOS clicking on points of interest the reaction is the same as clicking elsewhere on the map.

In the android code

null is a valid value. I adapted the iOS code to allow for the same behaviour.

[m0nac0]

Sounds reasonable, thanks for contributing.

Do you happen to have tested if null ids also work on web?

[lunaticcoding]

you're welcome :)

I just tried taking a look at web:

@JS()
@anonymous
class FeatureJsImpl {
  external dynamic get id;
  external set id(dynamic id);
  external String get type;
  external GeometryJsImpl get geometry;
  external dynamic get properties;
  external String get source;
  external factory FeatureJsImpl({
    dynamic id,
    String? type,
    GeometryJsImpl geometry,
    dynamic properties,
    String? source,
  });
}

As far as I can tell web seems to already support/allow null. I however have little experience with flutter web plugins.

[lunaticcoding]

@m0nac0 is it possible to get this merged soon? :) We need it for a client project.

[m0nac0]

There seem to be a few other places in the iOS code (e.g. onFeatureDrag) that seem to expect a non-null id.
But since it's already possible to add features with a null id and this fixes at least one issue with null-id-features, I'm approving it.

But please be cautioned that some other things may break if you set the id to null (e.g. I could imagine feature dragging on iOS not working correctly, but I haven't tested it). So adding features with id=null should be considered not to be officially supported.

[m0nac0]

Thanks again for contributing!