feat!: migrate maplibre-native for android to version 11.0.0 (take 2)
#406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josxha
changed the title
11.0.0 (take 2)
josxha
changed the title
11.0.0 (take 2)maplibre-native for android to version 11.0.0 (take 2)
josxha
force-pushed
the
feature/android-maplibre-11
branch
from
08da679 to
fd89483
Compare
kuhnroyal
reviewed
Jun 4, 2024
|
Fixed the version of the MapLibre plugins. |
|
We can do that separately. |
|
Sadly I only get black views instead of maps, something is wrong, not sure what. |
|
That's strange. It works fine for me on an physical device with android 11. |
|
Only simulator so far, but the main branch works on simulator. |
|
Could you check what android or sdk version it's using? Maybe it's related or similar to #327 which depends on the used OS version. |
|
Dunno why but it is working now :) |
|
And also works on device. |
Awesome!👍 |
kuhnroyal
approved these changes
Jun 5, 2024
|
Thanks again for the help on this pr! (: |
Remi-deronzier
pushed a commit
to viamichelin/flutter-maplibre-gl
that referenced
this pull request
Sep 6, 2024
…e 2) (maplibre#406) This pull request updates the package to use version 11.0.0 of maplibre-native for android. It superseeds maplibre#403 to make it not dependant on other pull requests. If wanted, we can change the occurences of "Maplibre" to "MapLibre" to be more in line with maplibre-native. (I'd prefer to do it in a follow-up pr tho).
Remi-deronzier
pushed a commit
to viamichelin/flutter-maplibre-gl
that referenced
this pull request
Sep 10, 2024
…e 2) (maplibre#406) This pull request updates the package to use version 11.0.0 of maplibre-native for android. It superseeds maplibre#403 to make it not dependant on other pull requests. If wanted, we can change the occurences of "Maplibre" to "MapLibre" to be more in line with maplibre-native. (I'd prefer to do it in a follow-up pr tho).
Remi-deronzier
pushed a commit
to viamichelin/flutter-maplibre-gl
that referenced
this pull request
Sep 10, 2024
…e 2) (maplibre#406) This pull request updates the package to use version 11.0.0 of maplibre-native for android. It superseeds maplibre#403 to make it not dependant on other pull requests. If wanted, we can change the occurences of "Maplibre" to "MapLibre" to be more in line with maplibre-native. (I'd prefer to do it in a follow-up pr tho).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the package to use version 11.0.0 of maplibre-native for android. It superseeds #403 to make it not dependant on other pull requests.
If wanted, we can change the occurences of "Maplibre" to "MapLibre" to be more in line with maplibre-native. (I'd prefer to do it in a follow-up pr tho).