-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare project for publishing #411
Conversation
* raise version to 0.19.0 * raise min Dart SDK to 3.0.0 as required by the `js: ^0.6.7` dependency * add `pubspec_overrides.yaml` files and move overridden local deps there * add `.pubignore` to prevent publishing unnecessary files * prepare new publish workflow * add supported platforms to `pubspec.yaml`
Changes are looking good to me. Two things that could get put into consideration:
╷
1 │ part of maplibre_gl;
│ ^^^^^^^^^^^^^^^^^^^^
╵
|
Yea, there are 26 issues. I'd rather release and fix them in a follow-up release. |
Both would get solved in #401. I'll split the changes into more pull requests, like requested in #401 (comment). About publishing the web package: The package uses resources from the MapTiler CDN at the moment, so I'm not sure if publishing would be good before it gets fixed. See here: #409 |
@kuhnroyal Just red #390 (comment) and wanted to ask if you consider this 0.9.0 release as a major or minor release? In flutter prior v1.0.0, a 0.8.0 to 0.9.0 version bump would normally be considered as a major breaking release, while 0.8.0 to 0.8.1 is a feature or minor release. Or like it ts described in the dart documentation:
|
Co-authored-by: Joscha <34318751+josxha@users.noreply.github.com>
Co-authored-by: Joscha <34318751+josxha@users.noreply.github.com>
@josxha I'd suggest we merge this and push a release tag to see what fails. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, let's focus on a release. 👍
We should update the documentation before we release. I opened a pull request for this here:
Only thing missing in that pull request is to add all changes that happend since the 0.18.0 version to the CHANGELOG.md file. I tried to track them in the v0.19.0 milestone
The main idea here is to get a the publishing working with the current state of the project. The `maplibre_gl_web` has never been published. With the new publishing workflow all packages will hopefully be published with a single tag ( `v0.19.0` in this case). * raise version to 0.19.0 * raise min Dart SDK to 3.0.0 as required by the `js: ^0.6.7` dependency * add `pubspec_overrides.yaml` files and move overridden local deps there * add `.pubignore` to prevent publishing unnecessary files * prepare new publish workflow * add supported platforms to `pubspec.yaml` * cancel in progress jobs if new commits are pushed * necessary lint fixes and formatting to satisfy Flutter version --------- Co-authored-by: Joscha <34318751+josxha@users.noreply.github.com>
The main idea here is to get a the publishing working with the current state of the project. The `maplibre_gl_web` has never been published. With the new publishing workflow all packages will hopefully be published with a single tag ( `v0.19.0` in this case). * raise version to 0.19.0 * raise min Dart SDK to 3.0.0 as required by the `js: ^0.6.7` dependency * add `pubspec_overrides.yaml` files and move overridden local deps there * add `.pubignore` to prevent publishing unnecessary files * prepare new publish workflow * add supported platforms to `pubspec.yaml` * cancel in progress jobs if new commits are pushed * necessary lint fixes and formatting to satisfy Flutter version --------- Co-authored-by: Joscha <34318751+josxha@users.noreply.github.com>
The main idea here is to get a the publishing working with the current state of the project. The `maplibre_gl_web` has never been published. With the new publishing workflow all packages will hopefully be published with a single tag ( `v0.19.0` in this case). * raise version to 0.19.0 * raise min Dart SDK to 3.0.0 as required by the `js: ^0.6.7` dependency * add `pubspec_overrides.yaml` files and move overridden local deps there * add `.pubignore` to prevent publishing unnecessary files * prepare new publish workflow * add supported platforms to `pubspec.yaml` * cancel in progress jobs if new commits are pushed * necessary lint fixes and formatting to satisfy Flutter version --------- Co-authored-by: Joscha <34318751+josxha@users.noreply.github.com>
The main idea here is to get a the publishing working with the current state of the project.
The
maplibre_gl_web
has never been published.With the new publishing workflow all packages will hopefully be published with a single tag (
v0.19.0
in this case).js: ^0.6.7
dependencypubspec_overrides.yaml
files and move overridden local deps there.pubignore
to prevent publishing unnecessary filespubspec.yaml