-
-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make showTileBoundaries prefer a vector source #1395
Conversation
I don't know why the render test doesn't trip. Manual test: The render test doesn't trip because it's a raster maxzoom of 1 and a vector maxzoom of 14. This adds a test with raster maxzoom of 17. Old behavior was to show tile boundaries for the raster source, and 0 kB. New behavior is to show tile boundaries and byte sizes for the vector tiles. |
Bundle size report: Size Change: +52 B
ℹ️ View DetailsNo major changes |
Can you please add tests and update the changelog.md file? |
Done, done. I note that https://github.com/maplibre/maplibre-gl-js/blob/main/CONTRIBUTING.md#changelog-conventions indicates to put changelog entries in the pull request. |
Any change for a unit test? |
Could factor out the logic to an exported function in either painter.ts or draw_debug.ts, then invoke it with various Maps and assert that it returns the desired SourceCache. The logic is currently inside a single 155-line function named render. |
Exporting the show tile boundaries to a different method/file and testing it would be great, thanks! |
Any updates on this? |
I think I can find some time this week. |
Any updates on this? I would really like to push this forward... |
@jleedev any news? |
Thanks for the code review. |
* Make showTileBoundaries prefer a vector source Fixes maplibre#833 * Add render test * Add changelog entry * Add render test * Add test for showTileBoundaries * eslint fix * typecheck fix * pass Style & zoom instead of Painter
Fixes #833