Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: contraint zoom >= 0 #1733

Closed

Conversation

sebastianoscarlopez
Copy link
Contributor

MapLibre allows negative zoom. Putting a constraint that zoom always must be greater than 0.

Example http://localhost:9966/test/debug-pages/terrain-osm.html#-0.07/0/32.8

If we add this constraint and test the example, the zoom will change to 0

Also, this will fix issue #1650

@HarelM
Copy link
Collaborator

HarelM commented Oct 16, 2022

Please add a test and a changelog entry.
The template is there for a reason... :-/

@github-actions
Copy link
Contributor

Bundle size report:

Size Change: 0 B
Total Size Before: 205 kB
Total Size After: 205 kB

Output file Before After Change
maplibre-gl.js 196 kB 196 kB 0 B
maplibre-gl.css 9.09 kB 9.09 kB 0 B
ℹ️ View Details No major changes

@sebastianoscarlopez
Copy link
Contributor Author

Please add a test and a changelog entry. The template is there for a reason... :-/

I see what you mean, @HarelM. Currently exists a snapshot test with zoom -1.

I am closing the pr.

PD: Please could you give me some guide why a negative zoom is ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants