Move kdbush to be a dependency instead of dev dependency

[HarelM]

Launch Checklist

kdbush was introduced in a recent PR.
When using version 3.0.0-pre.2 with typescript it saids that you need to install the kdbush types.
This is not a great expericence.
This is similar to geojson, point, vctor-tiles etc.

[github-actions]

Bundle size report:

Size Change: 0 B
Total Size Before: 208 kB
Total Size After: 208 kB

Output file	Before	After	Change
maplibre-gl.js	198 kB	198 kB	0 B
maplibre-gl.css	9.1 kB	9.1 kB	0 B

ℹ️ View Details

No major changes

[rotu]

This is puzzling to me. When is the above message happening?

Is kdbush an externalized dependency? It seems to me like it’s bundled and it (and certainly its types) should be under devDepencencies.

[HarelM]

The generated types definition is creating the maplibre.d.ts file with import KDBush from 'kdbush'; When using this without installing the types you'll get the following error.
It might be a limitation of the tool we are using to generate the maplibre.d.ts file, IDK...

[rotu]

Two things:

1. I think we should only export types for exposed interfaces (not sure how hard to make this change, but essentially --export-referenced-types)
2. In the near-term, we should use --external-inlines kdbush etc. so that the d.ts is self-contained.

[HarelM]

Feel free to try it out and replace this solution. I don't have a strong feelings about the current solution.
Note that inlining packages definitions might cause issue for people referencing these external libraries, I guess...
In any case, there's a bug that needs to be fixed in the current pre-release...

[rotu]

I don't really know what I'm doing here, but I gave it a whack in #2015.

[wipfli]

I think we had similar things in the past. If that fixes the issue for now I guess it is fine to merge...