Simplify test running in CI and locally #2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rotu
force-pushed
the
tests
branch
4 times, most recently
from
2a70ff9 to
2d31c8a
Compare
rotu
force-pushed
the
tests
branch
11 times, most recently
from
5c933eb to
caea3be
Compare
|
Bundle size report: Size Change: 0 B
ℹ️ View DetailsNo major changes |
rotu
force-pushed
the
tests
branch
13 times, most recently
from
0f60c70 to
b576ced
Compare
|
@HarelM Still in draft and a little stalled out. Don't worry about stepping on my toes here. |
consolidate jest tests under a single config Now you should be able to get meaningful results and IDE integration with simply "jest". Note that render tests are not included since they don't currently run under jest. wip remove extraneous X server fix and improve build tests style-spec fix style-spec build bump style-spec deps remove unnecessary dependency on node url package remove npm-plugin-playwright wip fix node version kick off eslint and stylelint via jest remove unused jest disable directives jest-runner-eslint ignore (grrr) use node lts fix config use jest builtin github action reporter revert eslint change Fail faster if gl package fails to return a context more wip more wip continue on error Update jest.config.ts Update test-all.yml Update jest.config.ts don't run eslint via jest update dependencies fix test script and remove test-unit-ci wip maybe fix test? i wonder if a 0-pixel framebuffer would work... maybe try filtering by path again wip refigure query tests (half the runtime and more readable) consolidate jest tests under a single config Now you should be able to get meaningful results and IDE integration with simply "jest". Note that render tests are not included since they don't currently run under jest. wip remove extraneous X server fix and improve build tests style-spec fix style-spec build bump style-spec deps remove unnecessary dependency on node url package remove npm-plugin-playwright wip fix node version kick off eslint and stylelint via jest remove unused jest disable directives jest-runner-eslint ignore (grrr) use node lts fix config use jest builtin github action reporter revert eslint change Fail faster if gl package fails to return a context more wip more wip continue on error Update jest.config.ts Update test-all.yml Update jest.config.ts don't run eslint via jest update dependencies fix test script and remove test-unit-ci wip maybe fix test? i wonder if a 0-pixel framebuffer would work... maybe try filtering by path again wip refigure query tests (half the runtime and more readable) consolidate jest tests under a single config Now you should be able to get meaningful results and IDE integration with simply "jest". Note that render tests are not included since they don't currently run under jest. wip remove extraneous X server fix and improve build tests style-spec fix style-spec build bump style-spec deps remove unnecessary dependency on node url package remove npm-plugin-playwright wip fix node version kick off eslint and stylelint via jest remove unused jest disable directives jest-runner-eslint ignore (grrr) use node lts fix config use jest builtin github action reporter revert eslint change Fail faster if gl package fails to return a context more wip more wip continue on error Update jest.config.ts Update test-all.yml Update jest.config.ts don't run eslint via jest update dependencies fix test script and remove test-unit-ci wip maybe fix test? i wonder if a 0-pixel framebuffer would work... maybe try filtering by path again wip refigure query tests (half the runtime and more readable) consolidate jest tests under a single config Now you should be able to get meaningful results and IDE integration with simply "jest". Note that render tests are not included since they don't currently run under jest. wip remove extraneous X server fix and improve build tests style-spec fix style-spec build bump style-spec deps remove unnecessary dependency on node url package remove npm-plugin-playwright wip fix node version kick off eslint and stylelint via jest remove unused jest disable directives jest-runner-eslint ignore (grrr) use node lts fix config use jest builtin github action reporter revert eslint change Fail faster if gl package fails to return a context more wip more wip continue on error Update jest.config.ts Update test-all.yml Update jest.config.ts don't run eslint via jest update dependencies fix test script and remove test-unit-ci wip maybe fix test? i wonder if a 0-pixel framebuffer would work... maybe try filtering by path again wip refigure query tests (half the runtime and more readable) consolidate jest tests under a single config Now you should be able to get meaningful results and IDE integration with simply "jest". Note that render tests are not included since they don't currently run under jest. wip remove extraneous X server fix and improve build tests style-spec fix style-spec build bump style-spec deps remove unnecessary dependency on node url package remove npm-plugin-playwright wip fix node version kick off eslint and stylelint via jest remove unused jest disable directives jest-runner-eslint ignore (grrr) use node lts fix config use jest builtin github action reporter revert eslint change Fail faster if gl package fails to return a context more wip more wip continue on error Update jest.config.ts Update test-all.yml Update jest.config.ts don't run eslint via jest update dependencies fix test script and remove test-unit-ci wip maybe fix test? i wonder if a 0-pixel framebuffer would work... maybe try filtering by path again wip refigure query tests (half the runtime and more readable) revert changes to query tests wip: integration tests remove separate query test build step build dist before running integration tests with gl readmes add changelog reset unrelated changes
# Conflicts: # .github/workflows/build.yml
rotu
changed the title
I think you should be able to run the tests generically, but dig into failures with specificity. I don't actually expect users to care about render vs non-render tests locally, since both should be able to run non-interactively on a local machine. Is this still an issue? |
|
So the generation of the rest data is done in the test, right? |
HarelM
reviewed
Feb 3, 2023
|
This looks good in general, we can always improve according to feedback. |
Yep. The test data is not so much “generated” as pulled together from a bunch of separate folders. I got rid of the extra step so now editing the test cases will show up in the test results without having to run that script! |
rotu
force-pushed
the
tests
branch
3 times, most recently
from
05ae23a to
3d25395
Compare
HarelM
approved these changes
Feb 3, 2023
|
@rotu did this PR remove coverage from the CI? I don't see any coverage report in the CI in recent PRs... |
|
@HarelM I don't think we had any coverage reports before this PR. Could you link one of the coverage reports you're talking about? |
|
It was part of the CI, reported to the console. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you should be able to get meaningful results by simply running
jest. Ornpx majesticif you’re fancy and want a GUI.Also, IDE integration with Jest plugins should work better, since now it is unambiguous which configuration applies to which test.
Note that render tests are not currently included since they don't currently run under Jest.
Finally, I consolidated a bunch of testing scripts so you don’t get a bajillion notifications for each push to a PR branch.