Improve performance by processing style layers in parallel #2131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Style processing (createStyleLayer method) is one of the most expensive operations performed during initial load and also during style change. This takes anywhere from 100-400ms, depending on machine speed, number of layers, expressions used in style etc.
Currently: Styles are validated (If validation is enabled) --> Styles are processed on main thread (via createStyleLayer function) --> broadcasted to all worker threads --> Styles are processed on each worker thread (via createStyleLayer function).
New change: Styles are validated (If validation is enabled) --> broadcasted to all worker threads --> Styles are processed in parallel (via createStyleLayer function) on both main and worker thread.
Note: In our observation doing a prewarm or an external worker as per this PR (#2130), gives much better results as worker threads are ready by the time it gets the broadcast message to truly allow parallel processing.
Launch Checklist
CHANGELOG.md
under the## main
section.