Add method to enable/disable cooperative gestures #2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UIEvents like 'wheel' include properties for whether some keys are currently pressed, including ctrl and meta. [0] This should be less prone to error, specifically when the user presses or depresses one of these keys while the browser document is not active. Adds a debug page for cooperative gestures because this feature cannot be tested with a fullscreen map, and the only other test page is a fullscreen map. [0] https://w3c.github.io/uievents/#dom-mouseevent-ctrlkey
Fixes maplibre#2057 Also disable cooperative gestures in fullscreen, using these new methods (Fixes maplibre#1488)
HarelM
reviewed
Feb 8, 2023
HarelM
reviewed
Feb 8, 2023
HarelM
reviewed
Feb 8, 2023
HarelM
reviewed
Feb 8, 2023
HarelM
reviewed
Feb 8, 2023
HarelM
reviewed
Feb 8, 2023
|
Amazing work! Thanks!! |
The syntax is a bit odd. Background here: tc39/proposal-type-annotations#16
HarelM
reviewed
Feb 8, 2023
HarelM
reviewed
Feb 13, 2023
|
Overall looks good. Can you explain why the extra pan-x pan-y are needed now when they were not needed before? |
HarelM
approved these changes
Feb 13, 2023
|
Thanks for the help with the review! |
This was referenced Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add method to enable/disable cooperativeGestures (fixes #2057)
Disable cooperative gestures in fullscreen, using these new methods (fixes #1488)
Add a debug page for cooperative gestures because the feature cannot
be tested with a fullscreen map, and the only other test page is
a fullscreen map.
Change how meta key is detected for cooperative gestures
UIEvents like 'wheel' include properties for whether some keys are
currently pressed, including ctrl and meta. [0] This should be less
prone to error, specifically when the user presses or depresses one of
these keys while the browser document is not active.
[0] https://w3c.github.io/uievents/#dom-mouseevent-ctrlkey
Launch Checklist
CHANGELOG.mdunder the## mainsection.