Migrate toBounds method to be a static fromLngLat method in LngLatBounds #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
zhangyiatmicrosoft
changed the title
HarelM
reviewed
Feb 13, 2023
|
Overall, this looks good. Just a simple improvement if the type. |
HarelM
approved these changes
Feb 13, 2023
|
Why didn't the test run? Can you do a dummy commit? |
# Conflicts: # CHANGELOG.md
Merged and now should work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
Add types to LngLatBounds constructor.
remove toBounds
Create a static method called fromLngLat(lnglat, radius).
Fail build on all warnings to stop all future circular dependency problems
Confirm your changes do not include backports from Mapbox projects (unless with compliant license)
Briefly describe the changes in this PR.
Link to related issues.
Write tests for all new functionality.
Document any changes to public APIs.
Add an entry to
CHANGELOG.mdunder the## mainsection.