Ensure features property is typed as MapGeoJSONFeature[] on MapLayerMouseEvent and MapLayerTouchEvent. #2244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
MapLayerMouseEvent
andMapLayerTouchEvent
are typed with theirfeatures
property asGeoJSON.Feature[]
. However, the features returned on either of these events areMapGeoJSONFeature
s; they contain the additional properties of that interface (e.g.,layer
,source
,sourceLayer
, andstate
). In addition, it appears the unit tests already cast features returned onMapLayerMouseEvent
s toMapGeoJSONFeature[]
; see here for an example. This PR just corrects the types!Looking through the CHANGELOG, it appears
MapGeoJSONFeature
is a fairly new addition (2.1.8-pre.2), so I think this may just be on spot where the types got missed!Launch Checklist
CHANGELOG.md
under the## main
section.