-
-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accuracy-circle in geolocate fix #2450
Conversation
Accuracy-circle was going places, chaning size randomly, seams to be fixed with this
THANKS!! |
Sure, I am currently writing it but I am new to writing tests, how can I run the test individually? I get this error right now:
|
can you try flipping the backslash? i.e. |
That solved it, using tab flipped the slashes for some reason. However when running it it does not seam to update, adding a console.log does not display the content? |
Not sure what you mean, console.log should work in the tests, you need to scroll up as jest throws a lot of junk to the console... |
I managed to figure it out, I have now added a test, it is good? The new code passed, the old one does not. |
I have updated the test, it fails on the old one, success on the new one. It is the smaller radius test that fails on the old code. |
Fixes #2449
Accuracy-circle was going places, chaning size randomly, seams to be fixed with this.
Changes
Replace _updateCircleRadius in geolocate_control.ts because the calculation was wrong. Code fix heavily inspired from stackoverflow.
Before
The old "circleDiameter" calculations
After
Launch Checklist
CHANGELOG.md
under the## main
section.