Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict typecheck to generated d.ts file #2623

Merged
merged 5 commits into from
Jun 4, 2023
Merged

Add strict typecheck to generated d.ts file #2623

merged 5 commits into from
Jun 4, 2023

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Jun 2, 2023

Fixes #2588.

This adds a tsconfig file that is specific to the d.ts file in the dist folder in order to make sure that the generated file is following the strict mode.

@HarelM
Copy link
Collaborator Author

HarelM commented Jun 2, 2023

I've added the following comment to the dts-bundle-generator repo to suggest a way to do it without this "hack".
timocov/dts-bundle-generator#187 (comment)

@neodescis
Copy link
Collaborator

neodescis commented Jun 2, 2023

I like this approach! However, I noticed that the typecheck commands are not excluding the "staging" folder, and it was spitting out nonsensical errors on those files when I ran it. I'm guessing we should exclude that folder in the base tsconfig?

@HarelM
Copy link
Collaborator Author

HarelM commented Jun 3, 2023

Yes, staging should be ignored, but when I added it to the exclude list it didn't work, not sure why...

@HarelM HarelM requested a review from birkskyum June 3, 2023 17:51
@HarelM HarelM merged commit ade6999 into main Jun 4, 2023
@HarelM HarelM deleted the dist-null-check branch June 4, 2023 05:29
@birkskyum birkskyum mentioned this pull request Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error at build
3 participants