Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gesture detection for TapDragZoomHandler #2673

Merged
merged 4 commits into from
Jun 14, 2023

Conversation

mz8i
Copy link
Contributor

@mz8i mz8i commented Jun 13, 2023

Addresses #2474.

  • Added tests for TapDragZoomHandler (including one failing test for the "tap + tap far away" case)
  • Fix failing test - abort tap-drag-zoom gesture when taps are far away

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 🎉

Comparison is base (4606607) 73.76% compared to head (2b1185b) 73.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2673      +/-   ##
==========================================
+ Coverage   73.76%   73.81%   +0.05%     
==========================================
  Files         238      238              
  Lines       18922    18928       +6     
  Branches     4243     4244       +1     
==========================================
+ Hits        13958    13972      +14     
+ Misses       4964     4956       -8     
Impacted Files Coverage Δ
src/ui/handler/tap_drag_zoom.ts 92.98% <100.00%> (+16.51%) ⬆️
src/ui/handler/tap_recognizer.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mz8i mz8i marked this pull request as ready for review June 13, 2023 15:04
@HarelM HarelM merged commit 6794451 into maplibre:main Jun 14, 2023
@HarelM
Copy link
Collaborator

HarelM commented Jun 14, 2023

THANKS!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants