Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom layer comment and update type in jsdoc #269

Merged
merged 1 commit into from
Aug 29, 2021
Merged

Remove custom layer comment and update type in jsdoc #269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/style/style_layer/custom_style_layer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ import type Map from '../../ui/map';
import assert from 'assert';
import {mat4} from 'gl-matrix';

// careful of this change from matrix from Array<number> to mat4 as custom layer can be 2D or 3D
// this may or may not be an issue, investigate
type CustomRenderMethod = (gl: WebGLRenderingContext, matrix: mat4) => void;

/**
Expand Down Expand Up @@ -110,7 +108,7 @@ type CustomRenderMethod = (gl: WebGLRenderingContext, matrix: mat4) => void;
* @instance
* @name prerender
* @param {WebGLRenderingContext} gl The map's gl context.
* @param {Array<number>} matrix The map's camera matrix. It projects spherical mercator
* @param {mat4} matrix The map's camera matrix. It projects spherical mercator
* coordinates to gl coordinates. The mercator coordinate `[0, 0]` represents the
* top left corner of the mercator world and `[1, 1]` represents the bottom right corner. When
* the `renderingMode` is `"3d"`, the z coordinate is conformal. A box with identical x, y, and z
Expand Down