Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cooperated gestures example #2860

Merged
merged 3 commits into from
Jul 12, 2023
Merged

feat: add cooperated gestures example #2860

merged 3 commits into from
Jul 12, 2023

Conversation

visitskyworld
Copy link
Contributor

@visitskyworld visitskyworld commented Jul 12, 2023 •
edited
Loading

Closes #2819

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
    Added cooperated gestures example
  • Link to related issues.
    Cooperative gestures example #2819
  • Include before/after visuals or gifs if this PR includes visual changes.
    image
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (9caa574) 73.97% compared to head (0b98e48) 73.97%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2860   +/-   ##
=======================================
  Coverage   73.97%   73.97%           
=======================================
  Files         238      238           
  Lines       18996    18996           
  Branches     4281     4281           
=======================================
  Hits        14052    14052           
  Misses       4944     4944

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

HarelM
HarelM approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANKS!

@HarelM HarelM merged commit a270ec4 into maplibre:main Jul 12, 2023
HarelM pushed a commit that referenced this pull request Jul 14, 2023
@visitskyworld @HarelM
feat: add cooperated gestures example (#2860)
7023fca 
* feat: add cooperated gestures example

* fix: update coopertiveGestures config

* fix: changelog
HarelM added a commit that referenced this pull request Jul 20, 2023
@HarelM @visitskyworld
@manuelroth @ZeLonewolf @kajkal @dependabot @ambientlight @JabSYsEmb
Add min elevation parameter to transform to fix a problem in field of…
8c351c4 
… view with negative elevation (#2858)

* Add min elevation parameter to transform

* Fix lint, failing test

* Fix build tests

* Fix build test

* Fix terrain edge case where elevation is negative for camera but not for tile.

* Fully fix the problem with min elevation

* feat: update supported example (#2859)

* feat: update supported example

* feat: add changelog

* feat: add cooperated gestures example (#2860)

* feat: add cooperated gestures example

* fix: update coopertiveGestures config

* fix: changelog

* Remove cooperative gesture screen from accessibility tree (#2857)

* Remove cooperative gesture screen from a11y tree

* Add changelog item

* Add unit test which makes sure that cooperative gesture container element is hidden from a11y tree

* Improve documentation on Map and Camera classes (#2863)

* typedoc cleanup

* Fix comment formatting

* Lint fixes

* Remove incorrect event doc

* Replace tables with simple lists

* Fix lint

* Remove tables

* Remove unwanted file

* Fix build test

* Added a test to make sure it won't break in the future

* Added unit test

* Updated change log

* Bump @maplibre/maplibre-gl-style-spec from 19.2.1 to 19.2.2 (#2867)

* Remove unused 'name' parameter (#2872)

* Bump @rollup/plugin-commonjs from 25.0.2 to 25.0.3 (#2873)

Bumps [@rollup/plugin-commonjs](https://github.com/rollup/plugins/tree/HEAD/packages/commonjs) from 25.0.2 to 25.0.3.
- [Changelog](https://github.com/rollup/plugins/blob/master/packages/commonjs/CHANGELOG.md)
- [Commits](https://github.com/rollup/plugins/commits/commonjs-v25.0.3/packages/commonjs)

---
updated-dependencies:
- dependency-name: "@rollup/plugin-commonjs"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump pretty-bytes from 6.1.0 to 6.1.1 (#2875)

Bumps [pretty-bytes](https://github.com/sindresorhus/pretty-bytes) from 6.1.0 to 6.1.1.
- [Release notes](https://github.com/sindresorhus/pretty-bytes/releases)
- [Commits](sindresorhus/pretty-bytes@v6.1.0...v6.1.1)

---
updated-dependencies:
- dependency-name: pretty-bytes
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @types/jest from 29.5.2 to 29.5.3 (#2878)

Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 29.5.2 to 29.5.3.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest)

---
updated-dependencies:
- dependency-name: "@types/jest"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @types/react from 18.2.14 to 18.2.15 (#2881)

Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 18.2.14 to 18.2.15.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react)

---
updated-dependencies:
- dependency-name: "@types/react"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump devtools-protocol from 0.0.1167732 to 0.0.1170846 (#2883)

Bumps [devtools-protocol](https://github.com/ChromeDevTools/devtools-protocol) from 0.0.1167732 to 0.0.1170846.
- [Changelog](https://github.com/ChromeDevTools/devtools-protocol/blob/master/changelog.md)
- [Commits](ChromeDevTools/devtools-protocol@v0.0.1167732...v0.0.1170846)

---
updated-dependencies:
- dependency-name: devtools-protocol
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump eslint-plugin-jest from 27.2.2 to 27.2.3 (#2884)

Bumps [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) from 27.2.2 to 27.2.3.
- [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases)
- [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md)
- [Commits](jest-community/eslint-plugin-jest@v27.2.2...v27.2.3)

---
updated-dependencies:
- dependency-name: eslint-plugin-jest
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump eslint from 8.44.0 to 8.45.0 (#2879)

Bumps [eslint](https://github.com/eslint/eslint) from 8.44.0 to 8.45.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.44.0...v8.45.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* VectorTileWorkerSource: change reloadTile behavior to reload right away instead of waiting for previous parse to complete (#1874)

* reloadCallback needs to be checked in loadTile

* add test that would verify reloadCallback and parse called appropriately

* add changelog entry and lint fix

* remove unncessary tile read

* use jest.spyOn for mocking of WorkerTile.parse

* fix changelog

* rem rebase remnants

* eliminate reload callback - reparse instead and cancel or drop dependency requests in flight

* lint fix, remove unit tests that no longer apply

* add worker_tile tests

* Bump postcss from 8.4.25 to 8.4.26 (#2880)

Bumps [postcss](https://github.com/postcss/postcss) from 8.4.25 to 8.4.26.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.4.25...8.4.26)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @types/node from 20.4.1 to 20.4.2 (#2877)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.4.1 to 20.4.2.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump puppeteer from 20.8.0 to 20.8.2 (#2882)

Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 20.8.0 to 20.8.2.
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json)
- [Commits](puppeteer/puppeteer@puppeteer-v20.8.0...puppeteer-v20.8.2)

---
updated-dependencies:
- dependency-name: puppeteer
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @typescript-eslint/parser from 5.61.0 to 5.62.0 (#2876)

Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.61.0 to 5.62.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.62.0/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix broken links (#2888)

* Bump word-wrap from 1.2.3 to 1.2.4 (#2890)

Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix changelog

* Code review fixes

* Code review fixes

* Fix lint

* Fix build size

* Fix refactoring in tests

* Rename method according to code review

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: visitskyworld <96882365+visitskyworld@users.noreply.github.com>
Co-authored-by: Manuel Roth <manuel.roth@srf.ch>
Co-authored-by: Brian Sperlongano <zelonewolf@gmail.com>
Co-authored-by: Karol Leśniak <16785518+kajkal@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Taras Vozniuk <primary.taras.vozniuk@gmail.com>
Co-authored-by: JabSYsEmb <32222578+JabSYsEmb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarelM HarelM HarelM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cooperative gestures example
3 participants
@visitskyworld @codecov-commenter @HarelM