Fix Raster DEM source serialization #2895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neodescis
commented
Jul 21, 2023
| minzoom: 2, | ||
| maxzoom: 10 | ||
| }); | ||
| expect(source.serialize()).toStrictEqual({ |
There was a problem hiding this comment.
The regular toEqual() assertion doesn't fail on properties that are unexpectedly present but undefined, whereas toStrictEqual() does
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2895 +/- ##
==========================================
+ Coverage 74.48% 74.49% +0.01%
==========================================
Files 238 238
Lines 19002 19018 +16
Branches 4284 4285 +1
==========================================
+ Hits 14153 14167 +14
- Misses 4849 4851 +2
☔ View full report in Codecov by Sentry. |
HarelM
approved these changes
Jul 22, 2023
|
Thanks! Please add a changelog entry. |
|
Entry added! |
HarelM
approved these changes
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2889.
While investigating the issue, I determined that not only are undefined properties included when serializing, but not all relevant properties are included either (e.g. minzoom and maxzoom). However, I can see no reason to not just use the base class RasterTileSource's serialize() function directly. So, I've removed the function from RasterDEMTileSource, and added a test for both RasterTileSource and RasterDEMTileSource.
Launch Checklist
CHANGELOG.mdunder the## mainsection.