-
-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typings issues in 3.2.0 #2898
Conversation
…the typing where it is used instead of letting it be inferred
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2898 +/- ##
=======================================
Coverage 74.49% 74.49%
=======================================
Files 238 238
Lines 19018 19018
Branches 4285 4285
=======================================
Hits 14167 14167
Misses 4851 4851
☔ View full report in Codecov by Sentry. |
Overall this looks good, thanks! |
Also can you ping me privately on maplibre's Slack ("Harel Mazor" is my handle there)? |
Added a few more comments, thanks for bearing with me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall approved, thanks!
I've tested everything out I can think of:
|
Thanks! Feel free to create a version bump PR so we can release a new version with these fixes. |
Closes #2896.
() => NodeJS.Timeout
)Launch Checklist
CHANGELOG.md
under the## main
section.