Remove access token #298
Merged
Remove access token #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bundle size report: Size Change: -3.25 kB
ℹ️ View Details
|
|
@wipfli @lseelenbinder @fredj @nyurik @petr-pokorny-1 any chance for a review? There're not much here besides removing telemetry and mapbox access token... |
petr-pokorny-1
approved these changes
Sep 3, 2021
|
Looks good to me as well. Removing code that talks to mapbox servers is really a relief. Thanks for the cleanup Harel. One thing that can be improved is renaming of files. GitHub tells me for example that $ mv util/mapbox util/request_manager
$ git add util/request_managerIf instead you run only $ git mv util_mapbox util/request_managerGitHub will probably show that the file was renamed and which parts were then deleted. This would make reviewing easier. Let me know if I got something wrong. |
|
Regarding migrating from Mapbox v1 to MapLibre v2: We recently came up with the idea that |
|
I think it's better this way - take a look at the top of the file of mapbox. It says that if you change it you violate their terms and conditions. So I decided to delete it and add a file instead. |
|
@wipfli git does not really track file moves but detects them based on similarities, so |
|
Beautiful, I didn't know that. |
wipfli
referenced
this pull request
in wipfli/maplibre-gl-js
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for removing access token from the code.
This will replace #21 but the code changes are very similar.
This also fixes #216.
Replaces #293 due to merge conflicts...
maplibre-gl-jschangelog:<changelog></changelog>