Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update typing of getTerrain to be consistent with setTerrain #3020

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Update typing of getTerrain to be consistent with setTerrain #3020

merged 2 commits into from
Aug 22, 2023

Conversation

neodescis
Copy link
Collaborator

@neodescis neodescis commented Aug 22, 2023 •
edited
Loading

Related to #2993. Updates map.getTerrain() typing for consistency with map.setTerrain(), specifying that it may return null (i.e. if terrain is not set).

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@HarelM HarelM enabled auto-merge (squash) August 22, 2023 17:21
@HarelM HarelM merged commit 3e6aa0d into maplibre:main Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarelM HarelM HarelM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neodescis @HarelM