Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typedef localIdeographFontFamily #3895 #3896

Merged
merged 7 commits into from
Mar 25, 2024

Conversation

Kanahiro
Copy link
Contributor

@Kanahiro Kanahiro commented Mar 25, 2024

close #3895
This PR make no changes on behavior or functionality, only on type defnition of
TypeScript.

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.68%. Comparing base (ed8fee4) to head (a013112).
Report is 3 commits behind head on main.

❗ Current head a013112 differs from pull request most recent head 70afd0e. Consider uploading reports for the commit 70afd0e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3896      +/-   ##
==========================================
+ Coverage   86.29%   86.68%   +0.38%     
==========================================
  Files         241      241              
  Lines       32343    32343              
  Branches     1977     1989      +12     
==========================================
+ Hits        27912    28036     +124     
+ Misses       3511     3368     -143     
- Partials      920      939      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kanahiro Kanahiro marked this pull request as ready for review March 25, 2024 14:59
@HarelM HarelM merged commit c0aee04 into maplibre:main Mar 25, 2024
15 checks passed
@HarelM
Copy link
Collaborator

HarelM commented Mar 25, 2024

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type def of Map constructor option localIdeographFontFamily doesn't accept false
3 participants