Bump @mapbox/point-geometry from 0.1.0 to 1.0.0 #4393
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [@mapbox/point-geometry](https://github.com/mapbox/point-geometry) from 0.1.0 to 1.0.0. - [Release notes](https://github.com/mapbox/point-geometry/releases) - [Commits](mapbox/point-geometry@v0.1.0...v1.0.0) --- updated-dependencies: - dependency-name: "@mapbox/point-geometry" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Sorry for the trouble with the types! Also heads up that we're holding off on merging a similar change in GL JS because benchmarks show a significant perf regression on Pixel 4 (an older phone, Chrome / Android — more recent hardware shows no difference). Not sure what the culprit is in those updates, might be the change from |
|
OK, thanks for the update! |
|
Interestingly enough, this change caused the build size to increase dramatically too. |
|
@HarelM I'm not sure what the root cause is yet — maybe you could run some benchmarks (general map rendering performance before/after the upgrades) on your side? Might help track it down. |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #4393 +/- ##
==========================================
+ Coverage 87.65% 87.88% +0.22%
==========================================
Files 246 246
Lines 33375 33381 +6
Branches 2185 2181 -4
==========================================
+ Hits 29255 29336 +81
+ Misses 3123 3061 -62
+ Partials 997 984 -13 ☔ View full report in Codecov by Sentry. |
|
I'll start with the build size, as it should be easier to understand what changed, I hope. If I won't see anything out of the ordinary I'll turn to running the bench marks... |
This is likely because of |
|
Yes, it seems that pbf is indeed duplicated twice in the output file due to vt-pbf old dependency. |
|
I can't see a major difference in the benchmarks I run locally on my machine (which isn't saying much I guess). And it might be a bit slower, but not by a lot, it also changes a bit from run to run. |
|
In any case, the build size is currently what's holding this PR I believe. |
|
A newer version of @mapbox/point-geometry exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
|
@mourner any updates regarding |
|
I didn't manage to get to the bottom of the regression yet and put the upgrade on hold for now unfortunately (need to work on more urgent issues at the moment). Let me know if you find any clues. |
|
My question was more about |
|
@HarelM that one's tricky — I wanted to update it but couldn't properly set up all the dev dependencies, e.g. |
|
ahh, that has cpp stuff, so it's probably a pain :-/ |
Bumps @mapbox/point-geometry from 0.1.0 to 1.0.0.
Release notes
Sourced from
@mapbox/point-geometry's releases.Commits
ebc356d1.0.0d0d6492update docs995c108remove index.d.ts from repo (it's autogenerated)1d80440modernize (ESM, TypeScript types, NPM, GHA)bf471dcRemove nyc from deps (#15)b5aeeddAdd eslint, update deps (#14)e7301f4fix typo (#13)9090b2cDocument installing the namespaced package via npm168c466Merge pull request #8 from mapbox/namespace78cbc23Updated to mapbox npm namespaceMaintainer changes
This version was pushed to npm by mapbox-npm-06, a new releaser for
@mapbox/point-geometrysince your current version.You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)