-
-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vertical alignment in format
expression
#5043
Merged
HarelM
merged 55 commits into
maplibre:main
from
tomtom-forks:vertical-alignment-in-format-expression
Jan 28, 2025
Merged
Vertical alignment in format
expression
#5043
HarelM
merged 55 commits into
maplibre:main
from
tomtom-forks:vertical-alignment-in-format-expression
Jan 28, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
…into vertical-alignment-in-format-expression
…into vertical-alignment-in-format-expression
HarelM
reviewed
Jan 27, 2025
HarelM
reviewed
Jan 27, 2025
HarelM
reviewed
Jan 27, 2025
HarelM
reviewed
Jan 27, 2025
HarelM
reviewed
Jan 27, 2025
Added a few nitpicking, otherwise looks good, thanks! |
…into vertical-alignment-in-format-expression
HarelM
reviewed
Jan 28, 2025
HarelM
reviewed
Jan 28, 2025
…into vertical-alignment-in-format-expression
HarelM
approved these changes
Jan 28, 2025
HarelM
reviewed
Jan 28, 2025
test/integration/render/tests/text-field/formatted-vertical-align/style.json
Outdated
Show resolved
Hide resolved
HarelM
reviewed
Jan 28, 2025
test/integration/render/tests/text-field/formatted-vertical-align-line/style.json
Outdated
Show resolved
Hide resolved
Did a last review and added a minor comment about the render test. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue: maplibre-style-spec
This PR introduces implementation of vertical align property in format expression. It enables to specify how each section should be positioned in relation to biggest element in line. There are three possible options:
How to compare
To easily compare between current behaviour and new changes we build small comparison app. Please download
test.zip
, unpack and run eg. with VSC Live Server extension.maplibre-gl-dev-MAIN.js
file contains current maplibre-gl-js version. We've changed export variable tomaplibreglMain
.maplibre-gl-dev.js
contains maplibre-gl-js with changes from this PR.Download test package:
test.zip
Visual comparison
Screen.Recording.2024-11-13.at.17.55.12.mov
Launch Checklist
CHANGELOG.md
under the## main
section.Authors: @zbigniewmatysek-tomtom @stanislawpuda-tomtom