Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set defaultMaxPitch to 85 #56

Closed
wants to merge 2 commits into from
Closed

set defaultMaxPitch to 85 #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f063492
set defaultMaxPitch to 85
Jan 12, 2021
8804495
fix test about maxpitch
Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ui/map.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ const defaultMaxZoom = 22;

// the default values, but also the valid range
const defaultMinPitch = 0;
const defaultMaxPitch = 60;
const defaultMaxPitch = 85;

const defaultOptions = {
center: [0, 0],
Expand Down
4 changes: 2 additions & 2 deletions test/unit/ui/map.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -887,7 +887,7 @@ test('Map', (t) => {

t.test('#getMaxPitch', (t) => {
const map = createMap(t, {pitch: 0});
t.equal(map.getMaxPitch(), 60, 'returns default value');
t.equal(map.getMaxPitch(), 85, 'returns default value');
map.setMaxPitch(10);
t.equal(map.getMaxPitch(), 10, 'returns custom value');
t.end();
Expand Down Expand Up @@ -920,7 +920,7 @@ test('Map', (t) => {
t.test('throw on maxPitch greater than valid maxPitch at init', (t) => {
t.throws(() => {
createMap(t, {maxPitch: 90});
}, new Error(`maxPitch must be less than or equal to 60`));
}, new Error(`maxPitch must be less than or equal to 85`));
t.end();
});

Expand Down