Add point-geometry and vector-tile types #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bundle size report: Size Change: -646 B
ℹ️ View Details
|
|
@wipfli @birkskyum @astridx Ready for review. |
HarelM
changed the title
|
I think it might fix #790 too, not sure though... |
birkskyum
approved these changes
Jan 21, 2022
|
I got this message in the tsconfig.json
|
|
I removed vector-tile from there, it might be that there's a need to add @mapbix/vector-tile, I'm not sure. |
|
Yes, the IDE. I don't see any compile errors |
|
Thought it might be some cache, and sure enough restarting vscode fixed it. |
|
I moved one line from camera.js to point convert as it felt like it should be there when migrating to typescript. |
wipfli
approved these changes
Jan 22, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
Fixes #788
Added
point-geometryandvector-tiletypes packages.Relevant things to consider:
{x:number, y:number}object, which will break after this, I'm not sure I mind as the docs doesn't really support this. I removed the test around it. I can bring this code back, but it will need an API change of the object that is being sent, which again, feels wrong.Point.tsand reverted to usepoint-geomertysincevector-tileis using it and I wanted to keep the implementation aligned.register('Point', Point), I'm not sure this is a problem, need to check the 1.x branch, but I don't think it was ever there...