Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for issue #2117 #2148

Merged
merged 11 commits into from
Mar 7, 2024
Merged

Workaround for issue #2117 #2148

merged 11 commits into from
Mar 7, 2024

Conversation

stefankarschti
Copy link
Collaborator

Metal backend workaround for issue #2117.
Root cause: Annotation view recycling causes apparent freeze of map display: the rendering is done but the surface is not updated.

Ref #2117

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.36%. Comparing base (1ba9a47) to head (7e4d0a2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2148      +/-   ##
==========================================
- Coverage   58.40%   58.36%   -0.04%     
==========================================
  Files         575      575              
  Lines       28341    28343       +2     
  Branches    11376    11376              
==========================================
- Hits        16552    16542      -10     
- Misses       4162     4165       +3     
- Partials     7627     7636       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 27, 2024

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0%     -72  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2148-compared-to-main.txt

@stefankarschti stefankarschti marked this pull request as ready for review February 27, 2024 16:11
@louwers
Copy link
Collaborator

louwers commented Feb 27, 2024

@cgalvan For testing, would you like a pre-release, or can the team that needs this fix build from source?

@cgalvan
Copy link
Collaborator

cgalvan commented Feb 27, 2024

@cgalvan For testing, would you like a pre-release, or can the team that needs this fix build from source?

I've reached out to them and will let you know once they respond, thank you!

@cgalvan
Copy link
Collaborator

cgalvan commented Feb 27, 2024

@cgalvan For testing, would you like a pre-release, or can the team that needs this fix build from source?

I've reached out to them and will let you know once they respond, thank you!

They are going to build from source from the branch, I'll keep you posted, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working metal
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants