Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated defaultProps for functional component #431

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

RobertSasak
Copy link
Contributor

@RobertSasak RobertSasak commented Aug 11, 2024

Description

Fixes #430

Checklist

  • I have tested this on a device/simulator for each compatible OS
  • I formatted JS and TS files with running yarn lint:fix in the root folder
  • I have run tests via yarn test in the root folder
  • I updated the documentation with running yarn generate in the root folder
  • I mentioned this change in CHANGELOG.md
  • I updated the typings files (index.d.ts)
  • I added/updated a sample (/example)

Screenshot OR Video

@caspg
Copy link
Contributor

caspg commented Aug 22, 2024

Looking good 👍

@tyrauber
Copy link
Collaborator

Thank you for this. Looks like detox failed for iOS due to deployment target, but I'll fix that in main. Will get this in alpha.11.

@RobertSasak
Copy link
Contributor Author

Thank you for reviewing. Let me know if there is anything I can do. This is the only occurence of defaultProps.

@tyrauber tyrauber merged commit 49f5822 into maplibre:main Sep 9, 2024
3 of 4 checks passed
Copy link

github-actions bot commented Dec 2, 2024

🎉 This PR is included in version 10.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants