Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: restore support for Color instances in Color.parse #128

Merged

Conversation

kajkal
Copy link
Contributor

@kajkal kajkal commented Apr 16, 2023

Restore support for already parsed Color instances as one of the valid Color.parse arguments as it is still required by some of the "functions".
Bug introduced in #94.

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@HarelM HarelM merged commit faa621c into maplibre:main Apr 16, 2023
@HarelM
Copy link
Collaborator

HarelM commented Apr 16, 2023

Thanks for making sure everything is as expected!

@kajkal
Copy link
Contributor Author

kajkal commented Apr 16, 2023

Because of this bug, some render tests in PR #2376 do not pass.
I'm afraid that to fix this, a new release of maplibre-style-spec would be needed to allow the import of patched maplibre-style-spec in maplibre-gl-js :<

@HarelM
Copy link
Collaborator

HarelM commented Apr 17, 2023

I'll release one shortly.

@HarelM
Copy link
Collaborator

HarelM commented Apr 17, 2023

Can you please address the comment in the other PR before I release a new version so that for now there won't be a need to release another one for the small change?

@kajkal
Copy link
Contributor Author

kajkal commented Apr 17, 2023

I addressed the comments, changes in maplibre-style-spec will not be required. You can proceed with the release of a new version of maplibre-style-spec.

@HarelM
Copy link
Collaborator

HarelM commented Apr 17, 2023

I've just released a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants