-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Projection specifications #687
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #687 +/- ##
==========================================
+ Coverage 92.56% 92.60% +0.03%
==========================================
Files 104 105 +1
Lines 4616 4638 +22
Branches 1301 1306 +5
==========================================
+ Hits 4273 4295 +22
Misses 343 343 ☔ View full report in Codecov by Sentry. |
Is this to be understood as that the provided projection will be the one for low zoom levels, and then web-mercator on high zoom, and we'll add a transition at appropriate zoom levels? If so, and i'm probably overthinking it but better to do so early - do we see upcoming challenges to those assumptions that would favor something more explicit like e.g. a list of zoom-level: projection pairs? Or ability to at disable web-mercator transition, or control when it hits? |
The current implementation of globe transitions from globe to mercator without any zoom configurations or user input, it just does it. I don't know if we can actually keep the globe projection while zooming in further. |
That's a good point, as long as it's experimental this will do fine. |
Hi, it needs to do that at a certain zoom level, because otherwise 32 bit floats (or GPU inverse trigonometry) will run out of precision and artifacts will appear. The transition zoom level (and the animation duration) is currently not configurable, but it is just a few numbers and I don't see any reason why users shouldn't be able to adjust it. The current values (possibly good candidates for default values) make the transition virtually unnoticeable, while the artifacts are also well hidden. |
Launch Checklist
This PR adds the projection specification according to the discussion here:
This is still experimental.
The following is how the docs would look like:
CHANGELOG.md
under the## main
section.