-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add composite sources support WIP #107
Conversation
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 45.41% 46.08% +0.67%
==========================================
Files 13 14 +1
Lines 1319 1341 +22
==========================================
+ Hits 599 618 +19
- Misses 720 723 +3
Continue to review full report at Codecov.
|
@stepankuzmin do we might need to think about performance here? I noticed a performance hit on my local setup, as I increased the tables. I have to dig into the code a bit to see what is going on when registering a composite source. But any pointers from you might be useful. |
@stepankuzmin, with table sources, I think all column values are added to the tile. Is there some way to exclude columns or can this new composite source be extended to support function sources too? |
I've been running this branch daily for weeks now. No issues. |
Hey @stepankuzmin, many thanks to you and the rest of the team for this great piece of software. Any news on this PR? Sure would be handy to make it official. |
Hi everyone, Sorry for the delay, I'm refactoring this in my free time. I hope to ship it this month |
@stepankuzmin let us know if you need any help. Happy to fix the merge conflicts if you like. |
Hi everyone I've rewritten composite sources support in #184
Could you please try this new image? If everything works well for you, I'm going to release it as v0.6.0 |
This PR allows composing multiple table sources into one composite source. Table sources endpoints now support multiple tables in one request. E.g you can request tiles that contain data from multiple tables by listing the tables separated by a comma:
Using with Mapbox GL JS
You can try this docker image with composite sources support and give any feedback on this
Relates: #36