Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preferred encoding computation #1355

Merged
merged 1 commit into from
May 29, 2024
Merged

Fix preferred encoding computation #1355

merged 1 commit into from
May 29, 2024

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented May 29, 2024

  • Decides which encoding to use depending on both Accept-Encode and the preferred encoding (chooses the preferred one in case brotli and gzip have the same q value)
  • Uses gzip by default

This will fix #1315

Decides which encoding to use depending on both `Accept-Encode` and the preferred encoding (chooses the preferred one in case brotli and gzip have the same q value)
@nyurik nyurik merged commit e4228fb into maplibre:main May 29, 2024
19 checks passed
@nyurik nyurik deleted the pref-enc branch May 29, 2024 02:13
@danielrh
Copy link

I've measured a lot of brotli vs gzip comparisons, and have always found that with the appropriate settings brotli is faster to compress, decompress and results in smaller filesize at every comparable setting.

It sounds like something is amiss with some setting that would cause gzip to ever win in a fair comparison--it's just an older and less capable algorithm.
What was being measured here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

very slow queries through martin
3 participants