Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix day picker when clicking the first day of a range #1356

Closed
wants to merge 1 commit into from

Conversation

jtmiclat
Copy link
Contributor

@jtmiclat jtmiclat commented May 29, 2024

Filters were breaking when addToRange returned an undefined. This happens when the date you want to add is the start date of the range. Based on the react-day-picker, undefined range means neither from nor to where set.

I did the following to fix this

  1. Set from and to to be null when range is undefined to not break destructuring
  2. Add a condition to only update the tile url when all the needed query parameters are complete to prevent incomplete tile fetching
Screen.Recording.2024-05-29.at.23.09.19.mov

Closes #1193

@jtmiclat jtmiclat changed the title Fix day picker when clicking a the first day of a range Fix day picker when clicking the first day of a range May 29, 2024
Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@nyurik
Copy link
Member

nyurik commented Jun 13, 2024

@jtmiclat my sincere apologies - I didn't follow up on this and turns out CI does not auto-merge demo fixes. I just merged #1373 by @jokopriyono which I think fixes the same issue(?). It is deployed now, and seems like its working properly, but please retest. Thank you for looking at it!

@jtmiclat
Copy link
Contributor Author

Closing the MR as it was addressed in #1373 !

@jtmiclat jtmiclat closed this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website breaks when you click on Jan 1st in the demo
2 participants